Skip to content

Simplify edges in enclosed_tessellation #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jGaboardi merged 27 commits into from
Apr 8, 2025
Merged

Simplify edges in enclosed_tessellation #595

jGaboardi merged 27 commits into from
Apr 8, 2025

Conversation

@u3ks
Copy link
Collaborator

@u3ks u3ks commented Jun 12, 2024

Adding the option to simplify the enclosed tessellations & a filtering fix

martinfleis
martinfleis reviewed Jun 12, 2024
View reviewed changes
@codecov
Copy link

codecov bot commented Jun 12, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 89.28571% with 3 lines in your changes missing coverage. Please review.

Project coverage is 98.1%. Comparing base (4037c70) to head (6966136).
Report is 111 commits behind head on main.

Files with missing lines Patch % Lines
momepy/functional/_elements.py 57.1% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #595     +/-   ##
=======================================
+ Coverage   97.4%   98.1%   +0.7%     
=======================================
  Files         26      40     +14     
  Lines       4328    7250   +2922     
=======================================
+ Hits        4214    7113   +2899     
- Misses       114     137     +23
Files with missing lines Coverage Δ
momepy/functional/tests/test_elements.py 99.1% <100.0%> (ø)
momepy/functional/_elements.py 96.9% <57.1%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

martinfleis
martinfleis reviewed Jun 12, 2024
View reviewed changes
momepy/functional/_elements.py Outdated
from shapely import coverage_simplify

if len(blg) > 1:
if len(blg) >= 1:
Copy link
Member

@martinfleis martinfleis Jun 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if else please

martinfleis
martinfleis reviewed Jun 12, 2024
View reviewed changes
@martinfleis
Copy link
Member

martinfleis commented Jun 18, 2024

Please split simplification and the fix into two distinct PRs. The former will wait until we get shapely.coverage_simplify merged, while the latter shall be merged now.

@u3ks u3ks changed the title Tess single building & simplification Tess simplification Jun 20, 2024
@martinfleis martinfleis marked this pull request as ready for review April 7, 2025 10:09
@u3ks u3ks requested a review from martinfleis April 7, 2025 14:14
martinfleis
martinfleis reviewed Apr 8, 2025
View reviewed changes
u3ks and others added 2 commits April 8, 2025 14:57
@u3ks u3ks requested a review from martinfleis April 8, 2025 15:41
martinfleis
martinfleis reviewed Apr 8, 2025
View reviewed changes
@martinfleis martinfleis requested a review from jGaboardi April 8, 2025 16:07
@martinfleis martinfleis changed the title Tess simplification Simplify edges in enclosed_tessellation Apr 8, 2025
@martinfleis
Copy link
Member

martinfleis commented Apr 8, 2025

A note to myself - include the same in morphological_tessellation.

jGaboardi
jGaboardi approved these changes Apr 8, 2025
View reviewed changes
Copy link
Member

@jGaboardi jGaboardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: 🚀

@jGaboardi jGaboardi added the enhancement New feature or request label Apr 8, 2025
@jGaboardi jGaboardi merged commit 4e731c9 into pysal:main Apr 8, 2025
15 checks passed
@martinfleis martinfleis mentioned this pull request Apr 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jGaboardi jGaboardi jGaboardi approved these changes

@martinfleis martinfleis martinfleis approved these changes

Assignees

@u3ks u3ks

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@u3ks @martinfleis @jGaboardi